Aieee

[ralphmelton]

The annotation engine part of our code traumatizes me. The code reflects the political and social problems that were going on when it was written.

I thought I spotted a bug in the code that deserializes saved analysis trees.
I tried a test case, and it worked.
I looked more closely:
It turned out that the author of the deserialization code intended to do the wrong thing; she intended to iterate through the inputs of a node, instead of just reusing one input.
But she failed to implement her intention correctly; she didn't check the return value of the iterator, so when it failed, she just used the old input without realizing it.
So it worked after all.

This is not exactly two wrongs making a right. At best, this is two wrongs making a right with a heaping helping of AIEEEE!

Comments

Pretty bad

[mrpeck.livejournal.com]

I have to add that it's pretty bad when I look over and you are twitching and shivering due to the horrors of that code. That's the kind of behavior I'd expect from me. :)